Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-4837] Update "Using Webpack" section in README for importing ably from static files #1808

Merged
merged 1 commit into from
Jul 4, 2024
Merged

[ECO-4837] Update "Using Webpack" section in README for importing ably from static files #1808

merged 1 commit into from
Jul 4, 2024

Conversation

VeskeR
Copy link
Contributor

@VeskeR VeskeR commented Jul 3, 2024

Resolves #1792

@VeskeR VeskeR changed the title [ECO-4837] Update "Using Webpack" section in README [ECO-4837] Update "Using Webpack" section in README for resolving ably import Jul 3, 2024
@VeskeR VeskeR changed the title [ECO-4837] Update "Using Webpack" section in README for resolving ably import [ECO-4837] Update "Using Webpack" section in README for importing ably from static files Jul 3, 2024
@VeskeR VeskeR requested a review from ttypic July 3, 2024 06:40
ttypic
ttypic approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VeskeR VeskeR merged commit a1229af into main Jul 4, 2024
9 of 12 checks passed
@VeskeR VeskeR deleted the 1792/update-readme-using-webpack branch July 4, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update "Using WebPack" section in README about importing ably directly from static file
2 participants
@VeskeR @ttypic